Skip to content

fix: onClose event trigger CLOSE_EVENT #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: onClose event trigger CLOSE_EVENT #24

wants to merge 1 commit into from

Conversation

vachmara
Copy link

Description

@onClose event call the _toggleModal() function without triggering the CLOSE_EVENT.

When an user just click outside the modal to close it, the event is not triggered here :

web3modal-vue/src/Web3ModalVue.vue

Line 84 in cc95d43

this.on(CLOSE_EVENT, () => reject("Modal closed by user"));

Resolution

Change the handleback function to @onClose="onClose"

@vachmara vachmara changed the title Fix: onClose event trigger CLOSE_EVENT fix: onClose event trigger CLOSE_EVENT Apr 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@vachmara